Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(browserstack): add build names to browserstack automate runs #8069

Merged
merged 5 commits into from
Jan 20, 2022
Merged

chore(browserstack): add build names to browserstack automate runs #8069

merged 5 commits into from
Jan 20, 2022

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

Noticed that there was no way to differentiate between the next and canary Browserstack Automate runs. This will add the appropriate build names to the corresponding scripts.

Changelog

Changed

  • add --build-name flag to browserstack-cypress calls

@jeffchew jeffchew added the dev Needs some dev work label Jan 19, 2022
@jeffchew jeffchew requested a review from a team as a code owner January 19, 2022 14:29
@jeffchew jeffchew self-assigned this Jan 19, 2022
emyarod
emyarod approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Jan 19, 2022
Closed
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 19, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 20, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8069/index.html

Built with commit: 8ffc56852d9eab8f62345d5da219b4476ff1ede9

@kodiakhq kodiakhq bot merged commit af4fa5f into carbon-design-system:main Jan 20, 2022
@jeffchew jeffchew deleted the chore/browserstack-build-names branch February 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@emyarod emyarod emyarod approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffchew @ibmdotcom-bot @emyarod @annawen1